Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension) quick fix for vscode 1.94.x compatibility due to switch to ESM modules #853

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

devinea
Copy link
Member

@devinea devinea commented Oct 4, 2024

Fix error opening Application Wizard in VS Code 1.94.x+
image

Due to VSCode changing to ESM modules in this release https://code.visualstudio.com/updates/v1_93#_impact-of-ecmascript-module-esm-loading-of-vs-code require.main is now undefined.

@devinea devinea force-pushed the fix_for_vscode_1.94.0_compatibility branch from 64a3e05 to 652a055 Compare October 4, 2024 11:01
@devinea devinea changed the title Fix - quick fix for vscode 1.94.0 compatibility fix(extension) quick fix for vscode 1.94.x compatibility due to switch to ESM modules Oct 4, 2024
@devinea devinea force-pushed the fix_for_vscode_1.94.0_compatibility branch from 652a055 to d06f0f1 Compare October 4, 2024 11:03
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veredcon veredcon merged commit 823c0a5 into SAP:master Oct 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants